Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating version of react (and other deps) #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rontrolard
Copy link

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @rontrolard, Thank you for taking your time and effort to make our project better.

@rontrolard
Copy link
Author

#175

@sshyam-gupta
Copy link
Owner

Thank you @rontrolard for taking your time and contribution.

I tried to build the package and got some errors related to jsx-runtime.
https://www.npmjs.com/package/react-router-prompt/v/0.7.2-beta-1?activeTab=code
Check: / react-router-prompt / dist / react-router-prompt.umd.cjs

Also seems react-router now suggests to "👉 Replace react-router-dom with react-router"
https://reactrouter.com/upgrading/v6#upgrade-to-v7.

I also have to check if this change will support the v6 react-router or if I will have to bump to v0.8 instead and update the README with support logs.

@sshyam-gupta
Copy link
Owner

I have created #177 to support React@19 for now and will look onto react-router@7 seperately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants