Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run game step after commands have been received from all actors #112

Closed
ssube opened this issue Jun 4, 2021 · 0 comments
Closed

run game step after commands have been received from all actors #112

ssube opened this issue Jun 4, 2021 · 0 comments
Assignees
Labels
scope/state world state management status/fixed issues that have been fixed and confirmed type/feature
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Jun 4, 2021

As a precursor to #89 and adhoc stepping, do not assume the player's command will be received last, and wait for all active actors to submit a command before stepping the game. This will require some changes to event flow: players need to join before the room changes are broadcast, so the player actor service can bind to an actor/room, and the player actor will be correctly queued. The current flow will try to start stepping without player input, since they join after room changes, and each state step will use the default wait command for the player. With this queue in place, a turn timer should be relatively easy.

@ssube ssube added status/progress issues that are in progress type/feature scope/state world state management labels Jun 4, 2021
@ssube ssube added this to the v1.4 milestone Jun 4, 2021
@ssube ssube self-assigned this Jun 4, 2021
@ssube ssube modified the milestones: v1.4, v1.5 Jun 4, 2021
@ssube ssube closed this as completed in 61276f3 Jun 4, 2021
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/progress issues that are in progress labels Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/state world state management status/fixed issues that have been fixed and confirmed type/feature
Projects
None yet
Development

No branches or pull requests

1 participant