Merge pull request #352 from storyblok/bugfix/WORK-723-sb-group-button

fix(work-723): sbGroupButton fix component update when changing props
storyblok · Jan 17, 2023 · 66cebf0 · 66cebf0
2 parents bc3d4c0 + 0e00192
commit 66cebf0
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 12 deletions.
diff --git a/src/components/AvatarGroup/SbAvatarGroup.vue b/src/components/AvatarGroup/SbAvatarGroup.vue
@@ -46,7 +46,7 @@ export default {
     },
   },
 
-  emits: ['click'],
+  emits: ['click', 'toggle-visible-dropdown'],
 
   data() {
     return {

diff --git a/src/components/AvatarGroup/components/SbMoreAvatars.vue b/src/components/AvatarGroup/components/SbMoreAvatars.vue
@@ -50,7 +50,7 @@ export default {
     },
   },
 
-  emits: ['click'],
+  emits: ['click', 'toggle-avatars-dropdown'],
 
   data() {
     return {

diff --git a/src/components/Breadcrumbs/BreadcrumbItem.vue b/src/components/Breadcrumbs/BreadcrumbItem.vue
@@ -58,7 +58,10 @@ export default {
       type: String,
       default: null,
     },
-    to: [String, Object],
+    to: {
+      type: [String, Object],
+      default: null,
+    },
     replace: Boolean,
   },
 

diff --git a/src/components/Breadcrumbs/BreadcrumbLink.vue b/src/components/Breadcrumbs/BreadcrumbLink.vue
@@ -17,15 +17,30 @@ export default {
       type: String,
       default: null,
     },
-    title: String,
-    target: String,
+    title: {
+      type: String,
+      default: '',
+    },
+    target: {
+      type: String,
+      default: '',
+    },
     append: Boolean,
     disabled: Boolean,
     exact: Boolean,
-    exactActiveClass: String,
+    exactActiveClass: {
+      type: String,
+      default: '',
+    },
     link: Boolean,
-    href: String,
-    to: [String, Object],
+    href: {
+      type: String,
+      default: '',
+    },
+    to: {
+      type: [String, Object],
+      default: null,
+    },
     replace: Boolean,
   },
 

diff --git a/src/components/GroupButton/SbGroupButton.vue b/src/components/GroupButton/SbGroupButton.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="sb-group-button" :class="activeClasses" v-bind="$attrs">
-    <VNodes :vnodes="activeSlots" />
+    <VNodes :vnodes="activeSlots()" />
   </div>
 </template>
 
@@ -25,9 +25,11 @@ export default {
         'sb-group-button--has-spaces': this.hasSpaces,
       }
     },
+  },
+  methods: {
     activeSlots() {
       const children = this.$slots.default && this.$slots.default()
-      const chilrenWithProps = children
+      return children
         .filter((b) => b.__v_isVNode)
         .map((button) => {
           button.props = {
@@ -36,8 +38,6 @@ export default {
           }
           return button
         })
-
-      return chilrenWithProps
     },
   },
 }

diff --git a/src/components/GroupButton/group-button.scss b/src/components/GroupButton/group-button.scss
@@ -13,6 +13,7 @@
 
   &:not(&--has-spaces) {
     .sb-button {
+      margin: 0;
       border-radius: 0;
     }