Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/update2svelte5 #1122

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

atu-record
Copy link

hi @josefineschaefer,
I created a working branch for Svelte 5. hope this helps to speed up releasing v5 support.
cheers,
Amar

@roberto-butti
Copy link
Contributor

This is amazing! Thank you for sharing this PR ✨.
I will test it in the next days.
@edodusi and @alvarosabu 🚀

@edodusi edodusi added the improvement [Issue][PR] Refactor or code improvement label Dec 23, 2024
@roberto-butti
Copy link
Contributor

Hi @atu-record ,
I tested your branch locally, and it works great with Svelte 5, both using +page.ts and a server-side approach via +page.server.ts. Amazing job 🚀
This could serve as a solid foundation for the new major version of Storyblok Svelte (version 5).

In any case, based on my tests, the latest version of Storyblok Svelte appears to be compatible with Svelte 5. Did you encounter any issues? I mention this to identify a proper level of priority for the release of a new major version of Storyblok Svelte. (useful for @edodusi )

@atu-record
Copy link
Author

atu-record commented Dec 31, 2024

hi @roberto-butti,
when i updated the repo everything worked like a charm with @storyblok/js@3.1.9
the only issue I briefly encountered was with version https://publint.dev/@storyblok/js@3.2.0
as the package.json threw an error while importing. 3.2.1 works flawless again.
if I encounter anything during our projects I will come back to you. If you need anything else let me know.

@edodusi
Copy link
Contributor

edodusi commented Dec 31, 2024

Thank you @atu-record for your work and @roberto-butti for your review, I will look into this ASAP with the goal of crafting a new release fully supporting Svelte 5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement [Issue][PR] Refactor or code improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants