-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance windows support #30148
base: next
Are you sure you want to change the base?
Enhance windows support #30148
Conversation
Type mapping stubs used in the build process were injecting file-system relative paths. This change ensures they are module relative paths by replacing path.sep with /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
export * from '${join(upwards, downwards).replaceAll(sep, '/')}'; | ||
export type * from '${join(upwards, downwards).replaceAll(sep, '/')}'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using path.posix.join()
instead of join().replaceAll(sep, '/')
for more idiomatic path normalization in module specifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad greptile - that only works if both paths are already posix paths. otherwise you end up with
export * from '../src\index.ts';
Sigh. This having worked, once, I'm now getting the exceedingly unhelpful error:
edit: ah, good, a known nx issue: nrwl/nx#29429 Updating to 20.3 seemed to fix it |
This is a much more portable solution than referencing a shell script
What I did
Type mapping stubs used in the build process were injecting file-system relative paths. This change ensures they are module relative paths by replacing path.sep with /
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR modifies the type mapper file generation to ensure cross-platform compatibility by normalizing path separators in TypeScript declaration files, particularly important for Windows builds.
code/core/scripts/helpers/generateTypesMapperFiles.ts
to replace system-specific path separators with forward slashes usingreplaceAll(sep, '/')
.d.ts
files💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!