Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unecessary commonjs plugin #53

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Remove unecessary commonjs plugin #53

merged 2 commits into from
Sep 12, 2024

Conversation

alexandrebodin
Copy link
Member

What does it do?

Reomove unecessary commonjs plugin

  • It is already included automatically by vite and was actually creating conflicts

@alexandrebodin alexandrebodin self-assigned this Sep 10, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: da1f28f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexandrebodin
Copy link
Member Author

So currently this can't be merged.

  • Removing it fixes some of the frontend issues but breaks the BE

@alexandrebodin
Copy link
Member Author

linked to strapi/pack-up#15

@alexandrebodin
Copy link
Member Author

It's ready for review will update the versions once @jhoward1994 has confirmed

@jhoward1994
Copy link
Contributor

Tested with the SEO plugin migration with experimental 0.0.0-experimental.3ddc4bc338d159d83d4b4e1119dbda5e56f10cf4 and seems to work fine

Was that built from this branch?

@alexandrebodin
Copy link
Member Author

yes :)

@alexandrebodin
Copy link
Member Author

And based on strapi/pack-up#15

innerdvations
innerdvations previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (just don't forget to update the pack-up dependency once that's released 😆)

@alexandrebodin alexandrebodin marked this pull request as ready for review September 12, 2024 11:27
@alexandrebodin
Copy link
Member Author

Latest experimental 0.0.0-experimental.da1f28f10a1fa5dfe08e81dae5c1f68e7c25b0af

@alexandrebodin alexandrebodin changed the title Reomove unecessary commonjs plugin Remove unecessary commonjs plugin Sep 12, 2024
innerdvations
innerdvations approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

One concern is that now we see The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

Could we pass in the VITE_CJS_IGNORE_WARNING option since it's not something users have to worry about?

@alexandrebodin
Copy link
Member Author

🤔 I don't see how this PR would do that at all

@alexandrebodin
Copy link
Member Author

issue upstream. will merge and then update the pack-up dep separatly

@alexandrebodin alexandrebodin merged commit 4c9d898 into main Sep 12, 2024
2 checks passed
@alexandrebodin alexandrebodin deleted the chore/common-js branch September 12, 2024 14:10
This was referenced Sep 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@alexandrebodin alexandrebodin

Labels
pr: fix Bug fix source: sdk-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandrebodin @jhoward1994 @innerdvations