Fix surcharge param passing in dev-app and iOS bridge (#853)

* dont pass param if empty string * dont check updatePI to set surchargeNotice;
stripe · Nov 14, 2024 · f08d724 · f08d724
1 parent 6bc4073
commit f08d724
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/dev-app/src/screens/CollectCardPaymentScreen.tsx b/dev-app/src/screens/CollectCardPaymentScreen.tsx
@@ -352,7 +352,7 @@ export default function CollectCardPaymentScreen() {
       updatePaymentIntent: enableUpdatePaymentIntent,
       enableCustomerCancellation: enableCustomerCancellation,
       requestDynamicCurrencyConversion: requestDcc,
-      surchargeNotice: surchargeNotice,
+      surchargeNotice: surchargeNotice ? surchargeNotice : undefined,
     });
 
     if (error) {

diff --git a/ios/StripeTerminalReactNative.swift b/ios/StripeTerminalReactNative.swift
@@ -543,10 +543,7 @@ class StripeTerminalReactNative: RCTEventEmitter, DiscoveryDelegate, BluetoothRe
             .setUpdatePaymentIntent(updatePaymentIntent)
             .setEnableCustomerCancellation(enableCustomerCancellation)
             .setRequestDynamicCurrencyConversion(requestDynamicCurrencyConversion)
-
-        if updatePaymentIntent, let surchargeNoticeValue = surchargeNotice {
-            collectConfigBuilder.setSurchargeNotice(surchargeNoticeValue)
-        }
+            .setSurchargeNotice(surchargeNotice)
 
         if let eligibleAmount = params["tipEligibleAmount"] as? Int {
             do {