Improve test quality #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a source gives us an invalid utf8 sequence, ensure that it is replaced by a Unicode replacement character as expected. One of the semver-major changes in node 8 was to change string_decoder behaviour to better align with the implementation in v8 itself. Now that we have tests for the handling of incomplete utf8 sequences, this actually affects us. To account for this, use a simple version check to determine the expected string output of our bad-utf8 tests. For background see nodejs/node@24ef1e6775 Signed-off-by: Ryan Graham <r.m.graham@gmail.com>
The original tests were done as a minimal effort approach to fully exercising the API via the simple CLI wrapper. This approach does not work on Windows. While everything in this module is completely platform agnostic, it is better to be certain. Signed-off-by: Ryan Graham <r.m.graham@gmail.com>
The tests are all written to assume a single LF for newlines. Telling git about this allows the test fixtures to not get mangled when run on Windows. Signed-off-by: Ryan Graham <r.m.graham@gmail.com>
The majority of the uses of strong-log-transformer are for prefixing console output from multiple processes with a child process identifier and almost all of them make use of ANSI escape codes in the tags so that the output is suitably colorful. Since that's a common use, these tests will ensure that the current behaviour doesn't accidentally change. Signed-off-by: Ryan Graham <r.m.graham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a backport (and slight re-work) of the tests added in #8 to ensure that the existing functionality and behaviour is adequately tested before such a "large" re-write.