-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option only_status
#210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Sep 25, 2023
probably need to use `waiting`
the state is `waiting`
update description
@styfle Any more comments? |
styfle
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I updated to only_status: 'waiting'
for more flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers sometimes leave the workflows in queued state. This happens when you have a protected environment and deployment is waiting for approval. They sometimes do not approve and just leave the workflow pending waiting for a merge that will start a new workflow run and deploy from there multiple merges at once.
We need to cancel the older pending ones if new PR is merged but SKIP canceling workflows that are running as it might be dangerous to interrupt it. To play it safe we introduce
only_status: 'waiting'
in order to avoid canceling runs with statusin_progress
GitHub official implementation also does not support this option and they do not have plans to implement it soon, so we are adding it to this action