feat: FieldMerkleTree tree with arbitrary hasher
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleaning up Benchmarks Added some functions into field-testing\src\bench_func.rs which allows us to simplify the benchmarking code for BabyBear, Mersenne31 and Goldilocks. * fmt and clippy * Minor typos Good to keep benchmarks for add_throughput, sub_throughput comparable but using the save number of repetitions. * Comments Adding a few comments and adding in a simple constant controlling the number of repations.
Clippy gets slightly unhappy when compiled with AVX targeted. No meaningful changes here but should stop clippy complaining.
|
Replaced with updated version #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
FieldMerkleTreeto have a digest word that is different than a field element, while keeping the packing API in place by introducingPackedValuetrait as a super trait toPackedField.This saves the need to convert to field elements in each level of the tree.