feat: add u32 related hash functions #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirhemo
reviewed
Feb 27, 2024
| // Perform rejection sampling over the uniform range (0..log2_ceil(p)) | ||
| let sample_base = |inner: &mut Inner| loop { | ||
| let log_size = log2_ceil_u64(F::ORDER_U64).saturating_sub(1); | ||
| let bound = (1 << log_size) - 1; |
There was a problem hiding this comment.
The plonky3 sampling uses rejection sampling (probably changes since the last time you update the branch), so we should keep that in our versions as well
blake3/src/lib.rs
Outdated
| @@ -35,3 +35,35 @@ impl CryptographicHasher<u8, [u8; 32]> for Blake3 { | |||
| hasher.finalize().into() | |||
| } | |||
| } | |||
|
|
|||
| impl CryptographicHasher<u32, [u32; 8]> for Blake3 { | |||
There was a problem hiding this comment.
I think that we should have another struct Blake3zk or something that uses our precompiles, it could even be in the sp1 recursion crate. The reason is that we would eventually want the normal Blake3 to implement hashing on u32 (this might be useful for SIMD utilization. of the prover)
tamirhemo
approved these changes
Feb 28, 2024
huitseeker
added a commit
to huitseeker/sp1
that referenced
this pull request
Feb 29, 2024
- succinctlabs/plonky3#27 updated `SerializingChallenger32` to take a type parameter for an initial `HashChallenger` state, - Updates the `Challenger` type definition in the `baby_bear_keccak` and `baby_bear_blake3` modules to reflect what typed is used there (u8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.