Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize project properties and deprecate frameworks #104

Closed
wants to merge 9 commits into from
Closed

Centralize project properties and deprecate frameworks #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dca83eb
Centralize NuGet package versioning
sungaila Nov 27, 2024
5c66102
Centralize assembly/package version
sungaila Nov 27, 2024
120c10e
Update Unity test project to 6000.0.28f1
sungaila Nov 27, 2024
2e0c184
Remove target frameworks and console app
sungaila Nov 27, 2024
8a9e39f
Run SonarCloud on master branch only
sungaila Nov 27, 2024
d766fc1
Fix PDFtoImage.Build.slnf
sungaila Nov 27, 2024
939f919
Fix NuGet package references
sungaila Nov 27, 2024
967931d
Update expected test assets
sungaila Nov 27, 2024
ebea226
Update NuGet packages
sungaila Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ jobs:
sonarcloud:
name: SonarCloud
runs-on: windows-latest
if: (github.repository == 'sungaila/PDFtoImage' && success()) && (github.event_name != 'workflow_dispatch' && true || inputs.run_sonarcloud) == true
if: (github.repository == 'sungaila/PDFtoImage' && github.ref == 'refs/heads/master') || (github.event_name == 'workflow_dispatch' && inputs.run_sonarcloud) == true
steps:
- name: Checkout
uses: actions/checkout@main
Expand Down
30 changes: 0 additions & 30 deletions src/Console/Console.csproj
View file
Open in desktop

This file was deleted.

184 changes: 0 additions & 184 deletions src/Console/Program.cs
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/Console/Properties/PublishProfiles/DotNet.pubxml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/Console/Properties/PublishProfiles/DotNetFramework.pubxml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/Console/Properties/PublishProfiles/DotNetFramework481.pubxml
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<!-- Version -->
<PropertyGroup>
<VersionPrefix>5.0.0</VersionPrefix>
<VersionSuffix>preview.3</VersionSuffix>
</PropertyGroup>
</Project>
36 changes: 36 additions & 0 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="bblanchon.PDFium.Android" Version="133.0.6872" />
<PackageVersion Include="bblanchon.PDFium.iOS" Version="133.0.6872" />
<PackageVersion Include="bblanchon.PDFium.Linux" Version="133.0.6872" />
<PackageVersion Include="bblanchon.PDFium.macOS" Version="133.0.6872" />
<PackageVersion Include="bblanchon.PDFium.Win32" Version="133.0.6872" />
<PackageVersion Include="ByteSize" Version="2.1.2" />
<PackageVersion Include="Markdig.Signed" Version="0.38.0" />
<PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly" Version="9.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="9.0.0" PrivateAssets="all" />
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="9.0.0" />
<PackageVersion Include="Microsoft.Maui.Controls" Version="9.0.10" />
<PackageVersion Include="Microsoft.Maui.Controls.Compatibility" Version="9.0.10" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.2.14" />
<PackageVersion Include="MSTest.TestAdapter" Version="3.6.3" />
<PackageVersion Include="MSTest.TestFramework" Version="3.6.3" />
<PackageVersion Include="PatrickJahr.Blazor.FileHandling" Version="1.0.0" />
<PackageVersion Include="PatrickJahr.Blazor.WebShare" Version="1.0.0" />
<PackageVersion Include="SkiaSharp" Version="3.118.0-preview.1.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Android" Version="3.118.0-preview.1.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.iOS" Version="3.118.0-preview.1.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux.NoDependencies" Version="3.118.0-preview.1.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.macOS" Version="3.118.0-preview.1.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="3.118.0-preview.1.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="3.118.0-preview.1.2" />
<PackageVersion Include="Sungaila.PDFium.BlazorWebAssembly" Version="132.0.6826" />
<PackageVersion Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
<PackageVersion Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/FrameworkTests/AspNet/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<Project>
<!-- ignore Directory.Build.props from project root directory -->
</Project>
5 changes: 4 additions & 1 deletion src/FrameworkTests/MauiApp/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@ public partial class App : Application
public App()
{
InitializeComponent();
}

MainPage = new AppShell();
protected override Window CreateWindow(IActivationState? activationState)
{
return new Window(new AppShell());
}
}
}
7 changes: 4 additions & 3 deletions src/FrameworkTests/MauiApp/MauiApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<TargetPlatformMinVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.17763.0</TargetPlatformMinVersion>
<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'tizen'">6.5</SupportedOSPlatformVersion>
<EmbedAssembliesIntoApk>true</EmbedAssembliesIntoApk>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand All @@ -50,9 +51,9 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="9.0.0" />
<PackageReference Include="Microsoft.Maui.Controls" Version="9.0.10" />
<PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="9.0.10" />
<PackageReference Include="Microsoft.Extensions.Logging.Debug" />
<PackageReference Include="Microsoft.Maui.Controls" />
<PackageReference Include="Microsoft.Maui.Controls.Compatibility" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading
Loading