Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default values in object destructuring #14554

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

caiquetorres
Copy link
Contributor

@caiquetorres caiquetorres commented Dec 4, 2024

This PR addresses an issue where destructuring objects and arrays within an each block causes the compiler to break if the default value of a property contains a string with special characters like } or ]. The current validation logic does not correctly handle these cases and incorrectly interprets such characters when they are inside strings.

Additionally, the solution includes support for template string syntax, ensuring these are also handled appropriately.

Resolves #12131

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 1123629

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14554-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14554

@Ocean-OS
Copy link
Contributor

Ocean-OS commented Dec 5, 2024

To fix the failing lint test, run Prettier on your changed files.

@caiquetorres caiquetorres force-pushed the destructuring-closing-chars branch from 1961940 to 1123629 Compare December 5, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_pattern fails if brackets are in strings etc
3 participants