Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Replace unused variable hack with (void) #5067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Aug 13, 2024

No description provided.

@AZero13 AZero13 changed the title Replace dirty hack with (void)isHFSPlusCanonical; (NFC) Replace dirty hack with (void)isHFSPlusCanonical; Aug 13, 2024
@AZero13
Copy link
Contributor Author

AZero13 commented Aug 17, 2024

@compnerd Thoughts?

@AZero13
Copy link
Contributor Author

AZero13 commented Aug 17, 2024

@swift-ci please test

@AZero13 AZero13 changed the title (NFC) Replace dirty hack with (void)isHFSPlusCanonical; (NFC) Replace unused variable hack with (void) Aug 17, 2024
@compnerd
Copy link
Member

I'm not sure about the value of this change tbh. There is active work to re-core to swift-foundation and that will entirely remove CoreFoundation. In the mean time, this diverges from the internal copy of CoreFoundation which might make it more difficult to backport changes if critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants