Revert "[Linux] Enable build-ids. (#4995)"

[compnerd]

This reverts commit f186ff8. This is incorrectly being applied to Windows builds as well.

[compnerd]

@swift-ci please test

[parkera]

Do we just need to conditionalize this more instead of reverting it?

[compnerd]

I'd rather avoid the warning and then re-enable this once we have proper testing. I'm worried that we might need CMake changes.

[compnerd]

@swift-ci please test Linux platform

[al45tair]

Why is this a problem on Windows? Surely the check_linker_flag prevents the extra argument from being passed to the linker there?

[compnerd]

It doesn't seem to be preventing that from being passed to the invocation.

[al45tair]

Hmmm. In that case, what we should probably do is conditionalise the check_linker_flag test so it doesn't happen on Windows, in which case we then won't pass the build ID argument through. I'm guessing link.exe is treating the argument as a filename, which presumably means that the logic in CMake's check_linker_flag is too simplistic to catch this.