style: fix eslint error

swsoyee · Feb 6, 2021 · 438b1de · 438b1de
1 parent 5447f4c
commit 438b1de
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -11,5 +11,8 @@ module.exports = {
     sourceType: 'module',
   },
   rules: {
+    'max-len': ['error', { code: 150 }],
+    'no-eval': 'off',
+    'no-param-reassign': 'off',
   },
 };
diff --git a/inst/htmlwidgets/r3dmol.js b/inst/htmlwidgets/r3dmol.js
@@ -1,3 +1,4 @@
+/* global $ HTMLWidgets $3Dmol Shiny */
 const isAutoRenderFunction = [
   // Other
   'createModelFrom',
@@ -28,7 +29,7 @@ HTMLWidgets.widget({
 
   type: 'output',
 
-  factory: (el, width, height) => {
+  factory: (el) => {
     let initialized = false;
     const elementId = el.id;
     const container = document.getElementById(elementId);
@@ -75,24 +76,26 @@ HTMLWidgets.widget({
         // Save last call function name for auto render function call
         const lastCallFunction = x.api[numApiCalls - 1].method;
 
-        for (let i = 0; i < numApiCalls; i++) {
+        for (let i = 0; i < numApiCalls; i += 1) {
           const call = x.api[i];
           const { method } = call;
           delete call.method;
           try {
             evalFun(call);
             that[method](call);
-          } catch (err) { }
+          } catch (err) {
+            // continue regardless of error
+          }
         }
         // Auto render
-        if (isAutoRenderFunction.findIndex((el) => el === lastCallFunction) > -1) {
+        if (isAutoRenderFunction.findIndex((element) => element === lastCallFunction) > -1) {
           viewer.render();
         }
       },
 
-      resize: (width, height) => {
-        container.setAttribute('width', width);
-        container.setAttribute('height', height);
+      resize: (newWidth, newHeight) => {
+        container.setAttribute('width', newWidth);
+        container.setAttribute('height', newHeight);
       },
       render: () => viewer.render(),
       rotate: (params) => viewer.rotate(params.angle, params.axis, params.animationDuration, params.fixedPath),
@@ -190,15 +193,15 @@ if (HTMLWidgets.shinyMode) {
         if (el && el.widget) {
           delete message.id;
           el.widget[fxn](message);
-          if (isAutoRenderFunction.findIndex((el) => el === fxn) > -1) {
+          if (isAutoRenderFunction.findIndex((ele) => ele === fxn) > -1) {
             el.widget.render();
           }
         }
       },
     );
   };
 
-  for (let i = 0; i < functionList.length; i++) {
+  for (let i = 0; i < functionList.length; i += 1) {
     addShinyHandler(functionList[i])();
   }
 }