Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Actor Refactor #471

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Process Actor Refactor #471

merged 5 commits into from
Dec 27, 2024

Conversation

jordan-rash
Copy link
Contributor

Will close #464

Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
Copy link
Contributor

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is still in draft, but looks good in the current state.

@jordan-rash jordan-rash marked this pull request as ready for review December 27, 2024 18:57
@jordan-rash jordan-rash requested a review from a team as a code owner December 27, 2024 18:57
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/synadia-io/nex/node/internal/actors 12.45% (+0.10%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/synadia-io/nex/node/internal/actors/direct_start_agent.go 12.44% (ø) 201 25 176
github.com/synadia-io/nex/node/internal/actors/os_procs.go 0.00% (ø) 34 0 34
github.com/synadia-io/nex/node/internal/actors/process_actor.go 0.00% (ø) 107 (-8) 0 107 (-8)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@jordan-rash jordan-rash merged commit 6023ad4 into main Dec 27, 2024
8 checks passed
@jordan-rash jordan-rash deleted the process_actor branch December 27, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Process Actor Code
2 participants