Missing Control API Unit Tests

[jordan-rash]

No description provided.

[bruth]

The bulk of the review are comments on a handful of practices to improve the testing structure which will help simplify the tests and remove some redundancy.

[bruth]

LGTM. My only other comment would be whether it would make sense to consolidate some of the tests as subtests to remove the need to spin up all the boilerplate each time for the simpler interactions. For example, Ping and DirectPing are not state changing, so those could combined as subtests. As another example, the only difference between the AuctionDeployAnd* tests is finding the workload vs. listing, but all the other boilerplate is the same. The CopyWorkload test could also be a subtest.

[jordan-rash]

LGTM. My only other comment would be whether it would make sense to consolidate some of the tests as subtests to remove the need to spin up all the boilerplate each time for the simpler interactions. For example, Ping and DirectPing are not state changing, so those could combined as subtests. As another example, the only difference between the AuctionDeployAnd* tests is finding the workload vs. listing, but all the other boilerplate is the same. The CopyWorkload test could also be a subtest.

Now that there is an assertion lib in there, I agree with this. I thought before subtest made it too difficult to read....let me see if I can clean it up

EDIT: I think what I am going to do is merge this and move to the subtest approach in the next few weeks

[github-actions]

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/synadia-io/nex/api/nodecontrol	75.44% (+75.44%)	🌟
github.com/synadia-io/nex/api/nodecontrol/gen	0.00% (ø)
github.com/synadia-io/nex/cmd/nex	0.00% (ø)
github.com/synadia-io/nex/models	27.01% (+21.98%)	🌟
github.com/synadia-io/nex/node	9.23% (ø)
github.com/synadia-io/nex/node/internal/actors	12.91% (+0.46%)	👍

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/synadia-io/nex/api/nodecontrol/client.go	75.44% (+75.44%)	171	129 (+129)	42 (-129)	🌟
github.com/synadia-io/nex/api/nodecontrol/gen/node_info_response.go	0.00% (ø)	0	0	0
github.com/synadia-io/nex/api/nodecontrol/gen/node_ping_response.go	0.00% (ø)	0	0	0
github.com/synadia-io/nex/cmd/nex/node.go	0.00% (ø)	0	0	0
github.com/synadia-io/nex/models/node.go	0.00% (ø)	0	0	0
github.com/synadia-io/nex/models/node_options.go	21.62% (+12.10%)	148 (+43)	32 (+22)	116 (+21)	🎉
github.com/synadia-io/nex/node/internal/actors/control_api.go	0.00% (ø)	298 (-35)	0	298 (-35)
github.com/synadia-io/nex/node/internal/actors/control_api_conversions.go	0.00% (ø)	24 (-1)	0	24 (-1)
github.com/synadia-io/nex/node/node.go	8.07% (ø)	347	28	319

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

• github.com/synadia-io/nex/api/nodecontrol/client_test.go