Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use goakt testing framework #478

Merged
merged 11 commits into from
Jan 4, 2025
Merged

Use goakt testing framework #478

merged 11 commits into from
Jan 4, 2025

Conversation

jordan-rash
Copy link
Contributor

@jordan-rash jordan-rash commented Jan 2, 2025

Starts to test actors with embedded test harness

Depends on #477

… test package

Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
Signed-off-by: Jordan Rash <jordan@synadia.com>
@jordan-rash jordan-rash marked this pull request as ready for review January 3, 2025 02:57
@jordan-rash jordan-rash requested a review from a team as a code owner January 3, 2025 02:57
node/internal/actors/mock_node_test.go Outdated Show resolved Hide resolved
node/internal/actors/mock_node_test.go Outdated Show resolved Hide resolved
node/internal/actors/mock_node_test.go Outdated Show resolved Hide resolved
node/internal/actors/mock_node_test.go Outdated Show resolved Hide resolved
node/node_test.go Outdated Show resolved Hide resolved
Signed-off-by: Jordan Rash <jordan@synadia.com>
bruth
bruth previously approved these changes Jan 3, 2025
Signed-off-by: Jordan Rash <jordan@synadia.com>
jordan-rash and others added 2 commits January 3, 2025 15:38
Signed-off-by: Jordan Rash <jordan@synadia.com>
Copy link

github-actions bot commented Jan 3, 2025

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/synadia-io/nex/api/nodecontrol/gen 0.00% (ø)
github.com/synadia-io/nex/node 9.28% (+0.10%) 👍
github.com/synadia-io/nex/node/internal/actors 19.03% (+6.17%) 👍
github.com/synadia-io/nex/node/internal/actors/pb 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/synadia-io/nex/api/nodecontrol/gen/auction_response.go 0.00% (ø) 0 0 0
github.com/synadia-io/nex/node/internal/actors/agent_supervisor.go 43.75% (+43.75%) 32 14 (+14) 18 (-14) 🌟
github.com/synadia-io/nex/node/internal/actors/control_api_conversions.go 33.33% (+33.33%) 24 8 (+8) 16 (-8) 🌟
github.com/synadia-io/nex/node/internal/actors/pb/agents.pb.go 0.00% (ø) 0 0 0
github.com/synadia-io/nex/node/node.go 8.12% (+0.09%) 345 (-4) 28 317 (-4) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/synadia-io/nex/node/internal/actors/agent_supervisor_test.go
  • github.com/synadia-io/nex/node/internal/actors/artifacts_test.go
  • github.com/synadia-io/nex/node/internal/actors/control_api_test.go
  • github.com/synadia-io/nex/node/internal/actors/mock_node_test.go

Copy link
Contributor

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tests pass after the update)

@jordan-rash jordan-rash merged commit b0115bf into main Jan 4, 2025
8 checks passed
@jordan-rash jordan-rash deleted the test/actors branch January 4, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants