wording changes to remove ambiguity #876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolomb
reviewed
Sep 1, 2024
There was a problem hiding this comment.
Sorry, this is not really an improvement and makes it harder to understand for me. More "version" repetitions do not help. And right after the best version was defined, you reference it again by a different term (that was previously an example). If anything, the just defined best version should be named again, or the term dropped completely in favor of the global version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the "This" at the beginning of the sentence to more specifically refer to one of the three files described in the preceding sentence (local, others, global/"best").