Fix double free error #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See if |
I experimented with the fbdev and SDL backends and confirmed that it can run normally without |
Refine the proposed changes by revisiting the use of |
jserv
requested changes
Dec 8, 2024
jserv
requested changes
Dec 8, 2024
Removed the free(old) call from the _twin_queue_delete function, consolidating memory deallocation into the _twin_queue_review_order function. This change improves memory management and enhances the maintainability of the code. The fix was verified on the fbdev backend using GDB to confirm that old is properly freed during the execution of free(q) in the _twin_queue_review_order function. Additionally, on the same backend, AddressSanitizer was used to confirm the absence of memory leaks and double free issues. Close sysprog21#75
huaxinliao
force-pushed
the
Double_free
branch
from
c16c69c to
232542c
Compare
|
Thank @huaxinliao for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
free(old)call from the_twin_queue_deletefunction, consolidating memory deallocation into the_twin_queue_review_orderfunction. This change improves memory management and enhances the maintainability of the code.The fix was verified using GDB to confirm that old is properly freed during the execution of
free(q)in the_twin_queue_review_orderfunction. Additionally, AddressSanitizer was used to confirm the absence of memory leaks and double free issues.