-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
@@ -0,0 +1,23 @@ | |||
run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work for both python 2 and 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should Integrate it as part of travis build. Opinions @Raxerz @paavininanda @Buddhiprabha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyans29 what purpose shall it serve?
I have created this make file just to map larger python commands to shorter make commands.
i.e. instead of python bot.py run
, you can call make run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Raxerz it supports both Python 2 and 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay.. about version, rasa has support for both, but you must have chosen one of those and moved ahead with it right? APIs for python 2 and python 3 are different. I doubt we can build this code with both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyans29 I had used Python 3. And accordingly recommended this in the Documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.. I am saying that this code won't work with python 2. If you used python 3 which is a nice decision, everyone contributing in future will have to use python 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Got it.
ChatBot/domain.yml
Outdated
utter_ask_name: | ||
- "What's your name?" | ||
utter_ask_gender: | ||
- "About you, male or female?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess since we have the option of a third gender then we may have to ask this differently like "May I know your gender?"
"prev_utter_ask_age", | ||
"prev_check_age" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
@@ -0,0 +1 @@ | |||
{"py/object": "rasa_core.featurizers.MaxHistoryTrackerFeaturizer", "max_history": 3, "remove_duplicates": true, "state_featurizer": {"py/object": "rasa_core.featurizers.BinarySingleStateFeaturizer", "input_state_map": {"entity_age": 16, "entity_medicine": 15, "intent_Female": 13, "intent_Male": 12, "intent_affirm": 10, "intent_botPlace": 4, "intent_deny": 11, "intent_gender": 9, "intent_goodbye": 2, "intent_greet": 0, "intent_identity": 3, "intent_informThird": 14, "intent_intro": 6, "intent_medicines": 7, "intent_prevent": 5, "intent_safeMedicine": 8, "intent_thankyou": 1, "prev_action_listen": 20, "prev_action_patient_information": 34, "prev_action_restart": 21, "prev_action_suggest_normal": 36, "prev_action_suggest_pregnant": 35, "prev_check_age": 38, "prev_utter_ask_age": 37, "prev_utter_ask_gender": 32, "prev_utter_ask_name": 31, "prev_utter_ask_pregnant": 33, "prev_utter_default": 22, "prev_utter_goodbye": 24, "prev_utter_greet": 23, "prev_utter_identity": 26, "prev_utter_intro": 29, "prev_utter_medicines": 30, "prev_utter_place": 27, "prev_utter_prevent": 28, "prev_utter_youarewelcome": 25, "slot_age_0": 17, "slot_matches_0": 18, "slot_requested_slot_0": 19}, "num_features": 39, "slot_feature_len": 3, "user_feature_len": 17}, "use_intent_probabilities": false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line at the end of the file
@@ -0,0 +1 @@ | |||
{"class_name": "Sequential", "config": [{"class_name": "Masking", "config": {"name": "masking_1", "trainable": true, "batch_input_shape": [null, 3, 39], "dtype": "float32", "mask_value": -1}}, {"class_name": "LSTM", "config": {"name": "lstm_1", "trainable": true, "return_sequences": false, "return_state": false, "go_backwards": false, "stateful": false, "unroll": false, "units": 32, "activation": "tanh", "recurrent_activation": "hard_sigmoid", "use_bias": true, "kernel_initializer": {"class_name": "VarianceScaling", "config": {"scale": 1.0, "mode": "fan_avg", "distribution": "uniform", "seed": null}}, "recurrent_initializer": {"class_name": "Orthogonal", "config": {"gain": 1.0, "seed": null}}, "bias_initializer": {"class_name": "Zeros", "config": {}}, "unit_forget_bias": true, "kernel_regularizer": null, "recurrent_regularizer": null, "bias_regularizer": null, "activity_regularizer": null, "kernel_constraint": null, "recurrent_constraint": null, "bias_constraint": null, "dropout": 0.2, "recurrent_dropout": 0.0, "implementation": 1}}, {"class_name": "Dense", "config": {"name": "dense_1", "trainable": true, "batch_input_shape": [null, 32], "dtype": "float32", "units": 19, "activation": "linear", "use_bias": true, "kernel_initializer": {"class_name": "VarianceScaling", "config": {"scale": 1.0, "mode": "fan_avg", "distribution": "uniform", "seed": null}}, "bias_initializer": {"class_name": "Zeros", "config": {}}, "kernel_regularizer": null, "bias_regularizer": null, "activity_regularizer": null, "kernel_constraint": null, "bias_constraint": null}}, {"class_name": "Activation", "config": {"name": "activation_1", "trainable": true, "activation": "softmax"}}], "keras_version": "2.2.0", "backend": "tensorflow"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
@@ -0,0 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
"rasa_core.policies.memoization.MemoizationPolicy", | ||
"rasa_core.policies.keras_policy.KerasPolicy" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
"training_data": "training_data.json", | ||
"trained_at": "20180725-005152", | ||
"rasa_nlu_version": "0.12.0" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
ChatBot/nlu_model_config.yml
Outdated
#- name: "ner_synonyms" | ||
#- name: "intent_entity_featurizer_regex" | ||
#- name: "intent_featurizer_mitie" | ||
#- name: "intent_classifier_sklearn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
ChatBot/nlu_model_config.yml
Outdated
|
||
|
||
|
||
#language: "en" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all these comments required?
ChatBot/test-data.json
Outdated
{ | ||
"intent": "botPlace", | ||
"text": "Where you?" | ||
}, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the opening braces for this block should be on a new line
ChatBot/data/nlu_data/greet.md
Outdated
- Hola | ||
- Ola | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two new lines added..
ChatBot/data/nlu_data/informThird.md
Outdated
- why specify? | ||
- will not tell | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two newlines in so many files..
this.messages.push({message: {text: sentMessage}, status: 'sent-message'}); | ||
if (localStorage.getItem(DoctorchatComponent._localStorageKey)) { | ||
this._botService.getIntent(sentMessage).subscribe(intent => { | ||
this._botService.getResponse(sentMessage).subscribe(text => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a default timeout.. or some error handling done here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, done in the service code.
@lunayach
Am I missing something here? Can you please look into it? |
@Raxerz did you start the Bot server after installing all the dependencies. |
@lunayach fix the conflict and can you share the steps to set up the bot server |
@Raxerz you may follow the steps given in the beginning of the ChatBot wiki, https://github.com/systers/PC-Prep-Kit/wiki/ChatBot-Documentation |
154b2fd
to
a281fab
Compare
Addressed comments. |
"prev_action_check_medicine_normal", | ||
"prev_action_check_medicine_pregnant" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an autogenerated model file.
"prev_action_check_medicine_normal", | ||
"prev_action_check_medicine_pregnant" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these autogenerated.. if not add a new line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an autogenerated model file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor new line issues. You have to confirm if the files are autogenerated.
@paavininanda @Raxerz this can also be reviewed and merged.. have alook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change otherwise looks good.
ChatBot/data/nlu_data/intro.md
Outdated
- What is this? | ||
- Mosquito transmitted diseases | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra new line here
a281fab
to
ddd6d53
Compare
ddd6d53
to
27832b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyans29 This can be merged now 👍
Description
Shifted to new more robust and scalable ChatBot built on top of Rasa Core using Rasa NLU as processing pipeline.
Fixes #132, #133
Type of Change:
How Has This Been Tested?
Evaluated the model using cross-validation.
Precision, f1-score, Confusion matrix etc. were recorded.
Checklist:
Code/Quality Assurance Only