feat(kit): `InputPin` add new component #10084

waterplea · 2024-12-27T12:09:30Z

Fixes #6521

lumberjack-bot · 2024-12-27T12:09:36Z

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

codecov · 2024-12-27T12:18:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (824da0c) to head (3b43bf8).
Report is 2 commits behind head on main.

Additional details and impacted files

@@      Coverage Diff      @@
##   main   #10084   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-27T12:18:44Z

Visit the preview URL for this PR (updated for commit 3b43bf8):

https://taiga-previews-demo--pr10084-pin-demo-1hpxa3ze.web.app

_{(expires Mon, 30 Dec 2024 11:23:57 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37}

bundlemon · 2024-12-27T12:21:01Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	308.25KB (+738B +0.23%)	+10%
✅	demo/browser/runtime.(hash).js	44.66KB (+170B +0.37%)	+10%

Unchanged files (3)

Status	Path	Size	Limits
✅	demo/browser/vendor.(hash).js	260.27KB	+10%
✅	demo/browser/styles.(hash).css	20.21KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +908B +0.14%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.55MB (+52.86KB +0.69%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

projects/kit/components/input-pin/input-pin.component.ts

projects/demo/src/modules/components/input-pin/examples/1/index.html

projects/demo/src/modules/components/input-pin/index.html

projects/demo/src/modules/components/input-pin/examples/2/index.html

github-actions · 2024-12-29T11:03:37Z

Playwright test results

6 failed
2032 passed
82 skipped

Details

Open report ↗︎
2120 tests across 70 suites
16 minutes, 30 seconds
3b43bf8

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-pin
webkit › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-pin
chromium › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /components/input-pin
webkit › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /components/input-pin
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-pin
webkit › tests/demo/demo.pw.spec.ts › Demo › /components/input-pin

Skipped tests

webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with saved cards
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › expired field should be clickable after reset of prefilled value
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-code"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll after click on link with anchor
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [light mode]
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [dark mode]
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Submenu
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Form control
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Complex
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 320x480
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 720x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1024x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1620x1024
webkit › tests/core/surface/surface.pw.spec.ts › Surface › Layers
webkit › tests/kit/carousel/carousel.pw.spec.ts › Carousel › should show next item after drag
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear inputNumber.textfield value on blur
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the beginning of the track changes only nearest (left) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the end of the track changes only nearest (right) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click between two thumbs triggers only nearest thumb
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on right slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on left slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Left decreases by one step (after setting right thumb active via click)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set left thumb more than right thumb (by Arrow Right)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set right thumb less than left thumb (by ArrowLeft)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowUp increases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowDown decreases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the LEFT slider MORE THAN position of the RIGHT slider (by ArrowUp)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the RIGHT slider LESS THAN position of the LEFT slider (by ArrowDown)
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › decrease value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 2 steps
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › no extra margin after the last tab
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show settings in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show hint in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › A12y
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is visible when the input is focused
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for s size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for m size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for l size

waterplea requested a review from a team as a code owner December 27, 2024 12:09

waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 27, 2024 12:09

github-actions bot assigned waterplea Dec 27, 2024

splincode approved these changes Dec 27, 2024

View reviewed changes

nsbarsukov approved these changes Dec 27, 2024

View reviewed changes

projects/kit/components/input-pin/input-pin.component.ts Show resolved Hide resolved

projects/demo/src/modules/components/input-pin/examples/1/index.html Show resolved Hide resolved

github-actions bot added the ready to merge label Dec 27, 2024

nsbarsukov reviewed Dec 27, 2024

View reviewed changes

projects/demo/src/modules/components/input-pin/index.html Show resolved Hide resolved

nsbarsukov reviewed Dec 27, 2024

View reviewed changes

projects/demo/src/modules/components/input-pin/examples/2/index.html Show resolved Hide resolved

waterplea and others added 7 commits December 29, 2024 18:15

feat(kit): InputPin add new component

f04018f

chore: apply changes after linting [bot]

acb85e9

chore: fix

30310a8

chore: fix

2bf06d6

chore: fix

de1e204

chore: fix

59af5cf

chore: fix

3b43bf8

waterplea force-pushed the pin branch from 736904a to 3b43bf8 Compare December 29, 2024 11:19

waterplea merged commit 36b45fa into main Dec 30, 2024
36 checks passed

waterplea deleted the pin branch December 30, 2024 06:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kit): `InputPin` add new component #10084

feat(kit): `InputPin` add new component #10084

waterplea commented Dec 27, 2024

lumberjack-bot bot commented Dec 27, 2024 •

edited

Loading

codecov bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

bundlemon bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 29, 2024 •

edited

Loading

feat(kit): InputPin add new component #10084

feat(kit): InputPin add new component #10084

Conversation

waterplea commented Dec 27, 2024

lumberjack-bot bot commented Dec 27, 2024 • edited Loading

Pull request was closed ✔️

codecov bot commented Dec 27, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 27, 2024 • edited Loading

bundlemon bot commented Dec 27, 2024 • edited Loading

BundleMon

github-actions bot commented Dec 29, 2024 • edited Loading

Playwright test results

Details

feat(kit): `InputPin` add new component #10084

feat(kit): `InputPin` add new component #10084

lumberjack-bot bot commented Dec 27, 2024 •

edited

Loading

codecov bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

bundlemon bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 29, 2024 •

edited

Loading