Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): added tuiDropdownEnabled to exposed inputs of TuiWithDropdownOpen #10101

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

lightest
Copy link
Contributor

@lightest lightest commented Dec 29, 2024

fixes: #9752

@lightest lightest requested a review from a team as a code owner December 29, 2024 05:23
@lightest lightest requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 29, 2024 05:23
Copy link

lumberjack-bot bot commented Dec 29, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Dec 29, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
307.25KB (+24B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.27KB +10%
demo/browser/runtime.(hash).js
44.49KB +10%
demo/browser/styles.(hash).css
20.2KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +19B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.5MB (+120B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit 562bbc6 into taiga-family:main Dec 29, 2024
38 checks passed
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (a32d2a4) to head (dbb74b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10101       +/-   ##
===========================================
- Coverage   65.98%        0   -65.99%     
===========================================
  Files        1227        0     -1227     
  Lines       15997        0    -15997     
  Branches     2313        0     -2313     
===========================================
- Hits        10555        0    -10555     
+ Misses       5228        0     -5228     
+ Partials      214        0      -214     
Flag Coverage Δ
summary ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hakimio
Copy link
Contributor

hakimio commented Dec 29, 2024

@lightest Navigation search needs to be fixed since now the canOpen restriction doesn't work as it should:


and it might be a good idea to add tests for the search in navigation component.

@waterplea
Copy link
Collaborator

I'll take a look after new year, this is not really the same issue as I believe the intent there was not to just disable opening the dropdown but also closing it when the condition is not met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Textfield open input doesn't work as expected
4 participants