Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): ActiveZone do not exit zone when scrollable container becomes non-scrollable #8631

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(cdk): ActiveZone do not exit zone when scrollable container becomes non-scrollable #8631

merged 1 commit into from
Aug 22, 2024

Conversation

vladimirpotekhin
Copy link
Member

@vladimirpotekhin vladimirpotekhin commented Aug 21, 2024 •
edited
Loading

Closes #8579

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 21, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v3 label Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 94bcb54):

https://taiga-ui--pr8631-fix-active-zone-chro-2hxnma7w.web.app

(expires Fri, 23 Aug 2024 10:53:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 21, 2024 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 397.56KB (+4.93KB +1.26%) +10%
✅ demo/browser/runtime.(hash).js
 41.94KB (+615B +1.45%) +10%
✅ demo/browser/vendor.(hash).js
 214.55KB (-25B -0.01%) +10%
Unchanged files (2)
Status Path Size Limits
✅ demo/browser/polyfills.(hash).js
 15.22KB +10%
✅ demo/browser/styles.(hash).css
 1.39KB +10%

Total files change +5.51KB +0.83%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.45MB (+37.82KB +1.53%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin marked this pull request as draft August 21, 2024 15:28
@vladimirpotekhin vladimirpotekhin marked this pull request as ready for review August 22, 2024 10:57
@splincode splincode merged commit 4b160f2 into v3.x Aug 22, 2024
32 checks passed
@splincode splincode deleted the fix-active-zone-chrome branch August 22, 2024 11:16
vladimirpotekhin added a commit that referenced this pull request Aug 22, 2024
@vladimirpotekhin
fix(cdk): ActiveZone do not exit zone when scrollable container bec…
54f651e 
…omes non-scrollable (#8631)
waterplea pushed a commit that referenced this pull request Aug 22, 2024
@vladimirpotekhin
fix(cdk): ActiveZone do not exit zone when scrollable container bec…
b796d0d 
…omes non-scrollable (#8631) (#8653)
This was referenced Aug 26, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladimirpotekhin @waterplea @splincode