-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize: bytes.Index and humanize.IBytes in SyncStandaloneReader #909
base: v4
Are you sure you want to change the base?
Conversation
Here's a question: Will doing this make the status interface unable to retrieve the humanized result? What if I want to view the status? In pkg: |
Currently Interface |
No no, you look at the |
Got it. Will check and fix it. |
@EquentR Issue resolved. |
@suxb201 看一下,好像是能提高一点点性能的样子 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你是正确的
/* If this was a diskless replication, we need to really put
* the slave online when the first ACK is received (which
* confirms slave is online and ready to get more data). */
if (c->repl_put_online_on_ack && c->replstate == SLAVE_STATE_ONLINE)
putSlaveOnline(c);
Opt:
EOF MARKER
Before:
After: