Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various DI improvements #449

Merged
merged 4 commits into from
Aug 28, 2024

chore: logging tweak

ffa14a6
Select commit
Loading
Failed to load commit list.
Merged

fix: various DI improvements #449

chore: logging tweak
ffa14a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 0s

51.02% (+0.39%) compared to ecfc5d6

View this Pull Request on Codecov

51.02% (+0.39%) compared to ecfc5d6

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.02%. Comparing base (ecfc5d6) to head (ffa14a6).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lightbulb/client.py 0.00% 5 Missing ⚠️
lightbulb/loaders.py 0.00% 1 Missing ⚠️
lightbulb/tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   50.62%   51.02%   +0.39%     
==========================================
  Files          34       34              
  Lines        2627     2636       +9     
==========================================
+ Hits         1330     1345      +15     
+ Misses       1297     1291       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.