avoid console warning when hitting number keys beyond pins (#599)

tc39 · Jun 8, 2024 · c0c4f82 · c0c4f82
1 parent 531d248
commit c0c4f82
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/js/menu.js b/js/menu.js
@@ -573,6 +573,7 @@ Menu.prototype.togglePinEntry = function (id) {
 };
 
 Menu.prototype.selectPin = function (num) {
+  if (num >= this.$pinList.children.length) return;
   document.location = this.$pinList.children[num].children[0].href;
 };
 

diff --git a/test/baselines/generated-reference/assets-inline.html b/test/baselines/generated-reference/assets-inline.html
@@ -657,6 +657,7 @@
 };
 
 Menu.prototype.selectPin = function (num) {
+  if (num >= this.$pinList.children.length) return;
   document.location = this.$pinList.children[num].children[0].href;
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -573,6 +573,7 @@ Menu.prototype.togglePinEntry = function (id) { @@
     };
     Menu.prototype.selectPin = function (num) {
+      if (num >= this.$pinList.children.length) return;
       document.location = this.$pinList.children[num].children[0].href;
     };
@@ Expand Down @@