Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for keyboard 0 selecting pin number 10 #561

Merged
merged 2 commits into from
Nov 3, 2023
Merged

add support for keyboard 0 selecting pin number 10 #561

merged 2 commits into from
Nov 3, 2023

Conversation

michaelficarra
Copy link
Member

Currently only 1-9 select pins 1-9. Adds support for 0 selecting pin 10.

@michaelficarra
Copy link
Member Author

Just to be certain, I checked https://en.wikipedia.org/wiki/Keyboard_layout and it seems like every keyboard layout in use around the world orders the numerals 1-9 followed by 0.

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross but I'll take it.

@bakkot bakkot merged commit 147364a into main Nov 3, 2023
2 checks passed
@bakkot bakkot deleted the zero branch November 3, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants