Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple test to validate declaration emit in presence of @internal #591

Closed
wants to merge 2 commits into from

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Mar 28, 2024

Ahead of actually fixing issues with the declarations, this adds a simple test that can be manually invoked to validate declaration emit in the presence of /* @internal */ and --stripInternal.

Long term, I would recommend refactoring out internals such that /* @internal */ is unnecessary.

Related: #416 (comment)

@bakkot
Copy link
Contributor

bakkot commented Mar 28, 2024

Merged as part of #592.

@bakkot bakkot closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants