Refactor typechecker #612
Merged
Refactor typechecker #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
force-pushed
the
refactor-typechecker
branch
from
bccd2f4 to
3082e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #611.
No functional changes except for the error messages in some cases. Commits can be reviewed individually, if you really want to, but it's not interesting other than the "split completion types in typechecker" commit, which splits the "completion" type into normal and abrupt. They can be union'd like any other types to represent "either a normal completion or an abrupt completion", instead of needing to keep track of it as a kind of ad-hoc union.
We don't refine "abrupt" because there's no point but it would be easy to do from here if it becomes necessary.