-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master v5 with native module #12
Open
github-numa-mau
wants to merge
58
commits into
master-v5
Choose a base branch
from
master-v5-with-native-module
base: master-v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Numa here it goes few more comments.
Is there a roadmap of everything you want to implement before it be available for publishers?
android/src/main/java/com/reactnativeteadssdkmodule/RNInReadAdPlacement.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativeteadssdkmodule/RNInReadAdPlacement.kt
Show resolved
Hide resolved
android/src/main/java/com/reactnativeteadssdkmodule/RNInReadAdPlacement.kt
Show resolved
Hide resolved
android/src/main/java/com/reactnativeteadssdkmodule/RNInReadAdPlacement.kt
Show resolved
Hide resolved
android/src/main/java/com/reactnativeteadssdkmodule/RNInReadAdPlacement.kt
Show resolved
Hide resolved
github-lucas-bon
approved these changes
Jun 13, 2023
github-lucas-bon
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the react-native-teads-sdk-module 🚀🚀
Let me know if you see something to change