-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make Connection#makeRequest
use async
/await
#1492
Open
arthurschreiber
wants to merge
15
commits into
master
Choose a base branch
from
arthur/refactor-make-request
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`/`await` as well
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
+ Coverage 79.83% 79.91% +0.07%
==========================================
Files 92 91 -1
Lines 4692 4765 +73
Branches 871 886 +15
==========================================
+ Hits 3746 3808 +62
+ Misses 673 667 -6
- Partials 273 290 +17
|
…thur/refactor-make-request
…thur/refactor-make-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
Connection#makeRequest
to be an async function, and to useasync
/await
to make the code flow more explicit.I pulled in all the logic from
enter
handlers of theSENT_CLIENT_REQUEST
andSENT_ATTENTION
states, soConnection#makeRequest
contains now all the logic of sending a request, handling cancellation, and reading the response.