Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move the loginError property from Connection into Login7Handler #1662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arthurschreiber
Copy link
Collaborator

One less thing to keep track of in the Connection class itself.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (e1b37fb) to head (9c85630).

Files with missing lines Patch % Lines
src/connection.ts 23.07% 10 Missing ⚠️
src/token/handler.ts 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   85.47%   85.26%   -0.21%     
==========================================
  Files          90       90              
  Lines        4859     4858       -1     
  Branches      924      924              
==========================================
- Hits         4153     4142      -11     
- Misses        702      712      +10     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant