Skip to content

Commit

Permalink
chore: second commit fixes test names and tf constraints (#3)
Browse files Browse the repository at this point in the history
* fix: remove tf version constraint

* fix: remove tf version constraint

* fix: change test name and tg name
  • Loading branch information
surajsbharadwaj authored Oct 19, 2023
1 parent 145537f commit 4498a1d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ You need the following permissions to run this module.

| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3, < 1.6.0 |
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >=1.49.0 |

### Modules
Expand Down
4 changes: 2 additions & 2 deletions examples/basic/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module "resource_group" {
# Create Transit gateway
#############################

resource "ibm_tg_gateway" "new_tg_gw" {
resource "ibm_tg_gateway" "transit_gateway" {
provider = ibm.ibm-is

name = "${var.prefix}-transit-gateway-1"
Expand All @@ -41,6 +41,6 @@ module "powervs_infra" {
pi_private_subnet_1 = var.powervs_private_subnet_1
pi_private_subnet_2 = var.powervs_private_subnet_2
pi_public_subnet_enable = var.powervs_public_network_enable
pi_transit_gateway_connection = { enable = true, transit_gateway_id = ibm_tg_gateway.new_tg_gw.id }
pi_transit_gateway_connection = { enable = true, transit_gateway_id = ibm_tg_gateway.transit_gateway.id }
pi_cloud_connection = var.powervs_cloud_connection
}
8 changes: 4 additions & 4 deletions tests/pr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,21 @@ func setupOptions(t *testing.T, prefix string, dir string) *testhelper.TestOptio
return options
}

func TestRunExample(t *testing.T) {
func TestRunBranchExample(t *testing.T) {
t.Parallel()

options := setupOptions(t, "pvs-ws-d", completeExampleDir)
options := setupOptions(t, "pvs-wsb", completeExampleDir)

output, err := options.RunTestConsistency()
assert.Nil(t, err, "This should not have errored")
assert.NotNil(t, output, "Expected some output")
}

func TestRunUpgradeExample(t *testing.T) {
func TestRunMainExample(t *testing.T) {
t.Parallel()

t.Skip("Skipping upgrade test until initial code is in master branch")
options := setupOptions(t, "pvs-ws-up", completeExampleDir)
options := setupOptions(t, "pvs-wsm", completeExampleDir)

output, err := options.RunTestUpgrade()
if !options.UpgradeTestSkipped {
Expand Down
2 changes: 1 addition & 1 deletion version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#####################################################

terraform {
required_version = ">= 1.3, < 1.6.0"
required_version = ">= 1.3"
required_providers {
# tflint-ignore: terraform_unused_required_providers
ibm = {
Expand Down

0 comments on commit 4498a1d

Please sign in to comment.