Add comments for Semi truck fields #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpkahn
force-pushed
the
akahn/document_semi_fields
branch
from
1b3cca9 to
bd7b60b
Compare
agbpatro
reviewed
Nov 29, 2023
aaronpkahn
force-pushed
the
akahn/document_semi_fields
branch
from
bd7b60b to
db0cded
Compare
agbpatro
reviewed
Nov 29, 2023
| @@ -1,7 +1,7 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Generated by the protocol buffer compiler. DO NOT EDIT! | |||
| # source: vehicle_metric.proto | |||
| # Protobuf Python Version: 4.25.0 | |||
| # Protobuf Python Version: 4.25.1 | |||
There was a problem hiding this comment.
you would need to update https://github.com/teslamotors/fleet-telemetry/blob/main/.github/workflows/build.yml#L22 and also readme
aaronpkahn
force-pushed
the
akahn/document_semi_fields
branch
from
db0cded to
7416cc3
Compare
agbpatro
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documents the Semi truck only fields.
Type of change
Checklist: