Fix profiler port #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmallet
force-pushed
the
fix-profiler-port
branch
from
ee1663b to
8d4db65
Compare
agbpatro
approved these changes
Dec 19, 2023
agbpatro
reviewed
Jan 3, 2024
test/integration/server_test.go
Outdated
| @@ -28,6 +28,7 @@ const ( | |||
|
|
|||
| serviceURL = "app:4443" | |||
| statusURL = "app:8080" | |||
| monitoringURL = "app:4269" | |||
There was a problem hiding this comment.
nit: monitoring more feels like prometheus/ metrics stuff. Should we rename to profilerURL or something like that instead?
There was a problem hiding this comment.
Definitely, much better. Addressed, finally!
Two endpoints should be on the profiler port rather than the main port: `gc_stats` and `live_profiler`. This is done by installing them on the default mux used by the profiler, rather than a custom mux passed on to the main server. Once `live_profiler` is on the internal profiler port, we can remove the `127.0.0.1` remote-ip restriction to make it easier to use, given that the default base image is a no-login image.
vmallet
force-pushed
the
fix-profiler-port
branch
from
8d4db65 to
00587e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two endpoints should be on the profiler port rather than the main port:
gc_statsandlive_profiler. This is done by installing them on the default mux used by the profiler, rather than a custom mux passed on to the main server.Once
live_profileris on the internal profiler port, we can remove the127.0.0.1remote-ip restriction to make it easier to use, given that the default base image is a no-login image.Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: