Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more descriptive error message #57

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

maximiliankolb
Copy link
Contributor

I have reworded the error message that is shown in Foreman if you try to run this job template on a managed hosts that does not have the "kernelcare" package installed.

Screenshot from 2023-10-13 14-34-38

cc @nadjaheitmann

@nadjaheitmann
Copy link
Collaborator

Tests are failing:
ArgumentError: wrong number of arguments (given 4, expected 1) /home/runner/work/foreman_kernel_care/foreman_kernel_care/vendor/bundle/ruby/2.5.0/gems/psych-5.1.0/lib/psych.rb:322:in 'safe_load' /opt/hostedtoolcache/Ruby/2.5.9/x64/lib/ruby/2.5.0/rubygems/safe_yaml.rb:31:in 'safe_load'

Could this be related to usage of double quotes in single quotes? Or is this just random? @maccelf Do you mind restarting the rubocop test?

@maccelf
Copy link
Member

maccelf commented Oct 13, 2023

@nadjaheitmann I am not sure about the error related to these changes. This error is related to installing dependencies via bundle

@nadjaheitmann
Copy link
Collaborator

Not sure either, the change looks very harmless. But we should try to figure out what happened or if this is just a hick up.

@nadjaheitmann
Copy link
Collaborator

Compared to the last successful bundle install run for rubocop tests, there is now psych 5.1.1, it was at psych 5.1.0 .

@nadjaheitmann
Copy link
Collaborator

#58 has the same error message for rubocop, so definitely unrelated. I think, we can try and fix rubocop in a separate PR.

@maccelf maccelf merged commit c9f05c3 into theforeman:master Oct 16, 2023
2 of 4 checks passed
@maximiliankolb maximiliankolb deleted the rename_error_message branch October 16, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants