✨ Handle all redirect codes for sub sites #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are proxying a website, and that site sends a redirect, we need to redirect through ourselves. This was only happening on a 301, but there are actually all kinds of redirect codes that have to be handled. As it turns out, fresh framework which Graphgen was using uses 302 for its redirects. This goes ahead and adds 302,307,308 to the list, so that we pick up all current and future redirects.
✅ Deploy Preview for frontside canceled.
|
taras
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we are proxying a website, and that site sends a redirect, we need to redirect through ourselves. This was only happening on a 301, but there are actually all kinds of redirect codes that have to be handled. As it turns out, fresh framework which Graphgen was using uses 302 for its redirects.
Approve
This goes ahead and adds 302,307,308 to the list, so that we pick up all current and future redirects.