fix: ensure drawMany feature labes are incremental (#495)

theopensystemslab · Sep 5, 2024 · f1d0421 · f1d0421
1 parent fd2b6b5
commit f1d0421
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/index.html b/index.html
@@ -52,6 +52,7 @@ <h1 style="color:red;font-size:16px;">
         maxZoom="23"
         drawMode
         drawMany
+        drawType="Point"
         basemap="MapboxSatellite"
         showCentreMarker
         osCopyright="© Crown copyright and database rights 2024 OS (0)100024857"

diff --git a/src/components/my-map/index.ts b/src/components/my-map/index.ts
@@ -561,9 +561,9 @@ export class MyMap extends LitElement {
         const sketches = drawingSource.getFeatures();
 
         // Assign a label to each feature based on its' index
-        sketches.forEach((sketch, i) => {
-          // If this feature already exists and is only being modified, use its' current label, else use index (needs to be type string in order to be parsed by Style "Text")
-          const label = sketch.get("label") || `${i + 1}`;
+        sketches.forEach((sketch) => {
+          // If this feature already exists and is only being modified, use its' current label, else use feature length (needs to be type string in order to be parsed by Style "Text")
+          const label = sketch.get("label") || `${sketches.length}`;
           sketch.set("label", label);
         });