Fix bug when deleting exclusive option

theopensystemslab · Jan 8, 2025 · 2247f2f · 2247f2f
1 parent 1f020b3
commit 2247f2f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/...r.planx.uk/src/@planx/components/Checklist/Editor/components/ExclusiveOrOptionManager.tsx b/...r.planx.uk/src/@planx/components/Checklist/Editor/components/ExclusiveOrOptionManager.tsx
@@ -37,6 +37,7 @@ export const ExclusiveOrOptionManager = ({
               if (grouped) {
                 const exclusiveOptionGroup = {
                   title: "Or",
+                  exclusive: true,
                   children: newExclusiveOptions,
                 };
                 const newCombinedOptions = [

diff --git a/editor.planx.uk/src/@planx/components/Checklist/Public/helpers.ts b/editor.planx.uk/src/@planx/components/Checklist/Public/helpers.ts
@@ -68,6 +68,7 @@ export const partitionGroupedOptions = (
   const [exclusiveOptionGroup, nonExclusiveOptionGroups] = partition(
     groupedOptions,
     (group: Group<Option>) =>
+      group.exclusive ||
       group.children.some((child) => child.data.exclusive === true),
   );
   return [exclusiveOptionGroup, nonExclusiveOptionGroups];

diff --git a/editor.planx.uk/src/@planx/components/Checklist/Public/tests/mockOptions.ts b/editor.planx.uk/src/@planx/components/Checklist/Public/tests/mockOptions.ts
@@ -153,6 +153,7 @@ export const groupedOptionsWithExclusiveOption: Array<Group<Option>> = [
   },
   {
     title: "Exclusive 'Or' Option",
+    exclusive: true,
     children: [
       {
         id: "exclusive_option",

diff --git a/editor.planx.uk/src/@planx/components/Checklist/model.ts b/editor.planx.uk/src/@planx/components/Checklist/model.ts
@@ -10,6 +10,7 @@ export enum ChecklistLayout {
 
 export interface Group<T> {
   title: string;
+  exclusive?: true;
   children: Array<T>;
 }