Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump planx-core #4121

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jan 9, 2025

See theopensystemslab/planx-core#614

Testing notes:

  • I've copied an "old" session from Bucks RAB production into this pizza database to confirm that the overview document maps display correctly
  • Login to the pizza editor to generate an auth token then open this admin endpoint in your browser: https://api.4121.planx.pizza/admin/session/12c48901-178d-445d-a550-783a36ba4bc1/html
    • Confirm that you have the subtext "The user accepted the title boundary" and a grey code block "boundary" populated
    • There's CORS errors in the console related the the OS maps display that are consistent with production that we can fix forward later (this seems to be specific to the admin endpoint and local downloads are fine)
    • But the presence of the subtext & "boundary" block are confirmation that variables are linking up again when compared to prod endpoint https://api.editor.planx.uk/admin/session/12c48901-178d-445d-a550-783a36ba4bc1/html

I've additionally confirmed that sessions started and submitted today (so only new data fields present) are correctly displaying documents and maps - download 115c6638-f77a-40d4-a653-2dc1ea342214 from here to confirm https://editor.planx.uk/gateshead/report-a-planning-breach/submissions-log

Copy link

github-actions bot commented Jan 9, 2025

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review January 9, 2025 10:58
@jessicamcinchak jessicamcinchak requested a review from a team January 9, 2025 10:58
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested following the description in the PR (thanks!) and getting expected results.

Agree that the CORS issue is unrelated - it's possibly been there since day 1 of the /html route and will only effect PlanX devs testing.

These files were intended for local consumption so CORS aren't a consideration. If I download the file the map works as expected.

image

@jessicamcinchak jessicamcinchak merged commit f52c06f into main Jan 9, 2025
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/bump-planx-core-e126742 branch January 9, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants