request: do not append '/j' in RawRequest() #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokokada
force-pushed
the
raw-reader-should-be-raw
branch
from
ba6f262 to
4fffa0d
Compare
This change moves the prefix of '/j' of the `RawRequest()` to `prepareRequests()` function instead. The prefix is used in Hyprland to indicate that the request needs to return JSON format, and while we always wants JSON format as response, someone using `RawRequest()` directly may not want to do so. While this is a breaking change for users of `RawRequest()`, the impact should be minimal and will allow for more flexibility in future. This also fixes a bug in batch mode, where we need to append '/j' in every command, not just the first one. It didn't affect the e.g. `Dispatch()` since it doesn't have a JSON output anyway, but it could affect something in the future.
thiagokokada
force-pushed
the
raw-reader-should-be-raw
branch
from
4fffa0d to
5f0b2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the prefix of '/j' of the
RawRequest()toprepareRequests()function instead. The prefix is used in Hyprland to indicate that the request needs to return JSON format, and while we always wants JSON format as response, someone usingRawRequest()directly may not want to do so.While this is a breaking change for users of
RawRequest(), the impact should be minimal and will allow for more flexibility in future.This also fixes a bug in batch mode, where we need to append '/j' in every command, not just the first one. It didn't affect the e.g.
Dispatch()since it doesn't have a JSON output anyway, but it could affect something in the future.