Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 and drop EOL 3.7-3.8 #65

Merged
merged 7 commits into from
Dec 29, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 16, 2024

@hugovk
Copy link
Contributor Author

hugovk commented Nov 16, 2024

The make build failures are from twine check:

build: commands[1]> twine check 'dist/*.whl' 'dist/*.tar.gz'
Checking dist/pytablewriter-1.2.0-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 156: Warning: Cannot scale image!                                 
           Could not get size from                                              
         "https://cdn.jsdelivr.net/gh/thombashi/pytablewriter@master/docs/pages/
         examples/table_format/text/ss/markdown.png":                           
           Requires Python Imaging Library.                                     
           Reading external files disabled.                                     
Checking dist/pytablewriter-1.2.0.tar.gz: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 156: Warning: Cannot scale image!                                 
           Could not get size from                                              
         "https://cdn.jsdelivr.net/gh/thombashi/pytablewriter@master/docs/pages/
         examples/table_format/text/ss/markdown.png":                           
           Requires Python Imaging Library.                                     
           Reading external files disabled.                                     

This is caused by pypa/readme_renderer#304.

Two suggestions:

  • remove the :scale: parts from README.rst
  • programmatically remove them when reading the file in setup.py

Copy link
Owner

@thombashi thombashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request and suggestions.
I will address the long_description problem.

@thombashi thombashi merged commit e445613 into thombashi:master Dec 29, 2024
21 of 22 checks passed
@thombashi
Copy link
Owner

Fixed at dc4d8c9

@hugovk hugovk deleted the add-3.13 branch December 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants