Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace APOSTROPHE with RIGHT SINGLE QUOTATION MARK in locale #1006

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Replace APOSTROPHE with RIGHT SINGLE QUOTATION MARK in locale #1006

merged 1 commit into from
Mar 18, 2024

Conversation

sej3506
Copy link
Contributor

@sej3506 sej3506 commented Mar 18, 2024

Replace APOSTROPHE (U+0027) with RIGHT SINGLE QUOTATION MARK (U+2019) in locale.
See rails/rails#45463

@sej3506
Replace APOSTROPHE with RIGHT SINGLE QUOTATION MARK in locale
feccecb 
Replace APOSTROPHE (U+0027) with RIGHT SINGLE QUOTATION MARK (U+2019) in locale.
See rails/rails#45463
@sej3506
Copy link
Contributor Author

sej3506 commented Mar 18, 2024

I'll be dropped support for Rails 2.76 shortly so am not concerned with the CI failure for that.

@stevepolitodesign
Copy link
Contributor

I thought this change was reverted? rails/rails#45463 (comment)

stefannibrasil
stefannibrasil approved these changes Mar 18, 2024
View reviewed changes
Copy link

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefannibrasil stefannibrasil merged commit 1396e7e into main Mar 18, 2024
17 of 18 checks passed
@stefannibrasil stefannibrasil deleted the replace-apostraphe-with-single-quote branch March 18, 2024 15:45
@dorianmariecom
Copy link
Contributor

I don't think it's a good idea, knowing that the change was reverted: rails/rails@acfa045

Revert typography change in user facing errors
This change would force a lot of existing applications and libraries
to update their tests.

We included it in the beta to collect feedback from the community and
we had some comments about how negative this change would be.

Developers that care about the typography of their error messages
can easily change it in their applications using the translation
files, so there is no need to inflict pain in the upgrade process
by changing the default in the framework.

@stefannibrasil stefannibrasil restored the replace-apostraphe-with-single-quote branch March 18, 2024 15:53
stefannibrasil pushed a commit that referenced this pull request Mar 18, 2024
Revert "Replace APOSTROPHE with RIGHT SINGLE QUOTATION MARK in locale (…
f8f31b7 
…#1006)"

This reverts commit 1396e7e.
@stefannibrasil stefannibrasil mentioned this pull request Mar 18, 2024
Merged
@stefannibrasil
Copy link

Oh, thanks! Reverted it in #1007

stefannibrasil pushed a commit that referenced this pull request Mar 18, 2024
Revert "Replace APOSTROPHE with RIGHT SINGLE QUOTATION MARK in locale (…
59bc147 
…#1006)" (#1007)

This reverts commit 1396e7e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sej3506 @stevepolitodesign @dorianmariecom @stefannibrasil