GateIO: Fix GetFuturesContractDetails for Deliveries and minor other fixes #1766
+87
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was returning the product of all the contracts, so 1444 instead of 38 contracts.
gbjk
force-pushed
the
bugfix/gateio_GetFuturesContractDetails
branch
from
282c54b to
cb7b226
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
==========================================
+ Coverage 37.37% 37.40% +0.03%
==========================================
Files 415 415
Lines 178627 178336 -291
==========================================
- Hits 66760 66715 -45
+ Misses 104089 103847 -242
+ Partials 7778 7774 -4
|
Using wrong error for pair not enabled
Especially fixes GetSingleContract, which seems misleading to not say Futures. There's a load of `GetSingle*` here that should probably also be fixed, but these two justified a dyno
gbjk
force-pushed
the
bugfix/gateio_GetFuturesContractDetails
branch
from
dcf0c6c to
77569e5
Compare
gbjk
changed the title
gbjk
force-pushed
the
bugfix/gateio_GetFuturesContractDetails
branch
from
77569e5 to
e0ceb88
Compare
gbjk
force-pushed
the
bugfix/gateio_GetFuturesContractDetails
branch
from
e0ceb88 to
ba00163
Compare
It's been a year, and I'm still getting caught out by govet demanding I don't shadow a var I was deliberately shadowing. Made worse by an increase in clashes with stylecheck when they both want opposite things on the same line.
gbjk
force-pushed
the
bugfix/gateio_GetFuturesContractDetails
branch
from
c19f66c to
f21d447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GateIO
Was returning the product of all the contracts, so 1444 instead of 38 contracts.
Doesn't touch anything else around this; Futures asset split coming separately
Linter
Type of change
How has this been tested