Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support council voting #834

Merged
merged 10 commits into from
Jan 6, 2025
Merged

Support council voting #834

merged 10 commits into from
Jan 6, 2025

Conversation

AhmedHanafy725
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 commented Jan 5, 2025 •
edited
Loading

Changes

  • support council voting

Related Issues

zaelgohary
zaelgohary reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All council changes in client give errors.

image

@AlaaElattar
Copy link
Contributor

can we make the voting dialog closes after the extrinsic succeed, It was a but confusing for me

@AhmedHanafy725 AhmedHanafy725 merged commit 21f55de into development Jan 6, 2025
1 check failed
@AhmedHanafy725 AhmedHanafy725 deleted the development_council branch January 6, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AhmedHanafy725 @AlaaElattar @zaelgohary