Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiarchitecture support #118

Closed
wants to merge 3 commits into from
Closed

Conversation

tedivm
Copy link

@tedivm tedivm commented Sep 23, 2021

This builds off of the PR in the upstream repo.

It will not work until that has been merged and the images published.

@tedivm
Copy link
Author

tedivm commented Nov 1, 2021

I've created a new project called Multi-Py that builds multiplatform containers.

The new organization now has the following multi platform images-

They're pretty stable now should anyone want to use them, and should be a mostly drop in replacement for this project.

@mileo
Copy link

mileo commented Mar 9, 2022

Very useful

tordans added a commit to FixMyBerlin/atlas-geo that referenced this pull request Nov 13, 2023
The thing we used before does not support ARM64. There are open issues since 2021 https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker/issues?q=is%3Aissue+is%3Aopen+arm64

One user created new project called Multi-Py that builds multiplatform containers. See tiangolo/uvicorn-gunicorn-fastapi-docker#118 and https://github.com/multi-py/python-uvicorn
rush42 pushed a commit to FixMyBerlin/atlas-app that referenced this pull request Jul 15, 2024
The thing we used before does not support ARM64. There are open issues since 2021 https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker/issues?q=is%3Aissue+is%3Aopen+arm64

One user created new project called Multi-Py that builds multiplatform containers. See tiangolo/uvicorn-gunicorn-fastapi-docker#118 and https://github.com/multi-py/python-uvicorn
rush42 pushed a commit to FixMyBerlin/atlas-app that referenced this pull request Jul 15, 2024
The thing we used before does not support ARM64. There are open issues since 2021 https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker/issues?q=is%3Aissue+is%3Aopen+arm64

One user created new project called Multi-Py that builds multiplatform containers. See tiangolo/uvicorn-gunicorn-fastapi-docker#118 and https://github.com/multi-py/python-uvicorn
@tiangolo
Copy link
Owner

tiangolo commented Aug 25, 2024

Thank you! 🍰

Now that Uvicorn supports managing workers with --workers, including restarting dead ones, there's no need for Gunicorn. That also means that it's much simpler to build a Docker image from scratch now, I updated the docs to explain it.

Because of that, I deprecated this Docker image: https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker#-warning-you-probably-dont-need-this-docker-image

That also means that by building your Dockerfile based on the official Python you will get multi-arch by default. 😎

Given that I'll close this one, but thanks for the effort! ☕

@tiangolo tiangolo closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants