make vol change handling on generic funct

tikservices · Dec 20, 2014 · aeb40b5 · aeb40b5
1 parent 1938fb0
commit aeb40b5
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 30 deletions.
diff --git a/.jshintrc b/.jshintrc
@@ -61,6 +61,7 @@
     "onReady",
     "onInit",
     "getPreferredFmt",
+    "handleVolChange",
     "asyncGet"
   ]
 }
diff --git a/data/break.js b/data/break.js
@@ -40,11 +40,7 @@
         document.body.innerHTML = "";
         document.head.innerHTML = "";
         document.body.appendChild(player);
-        onPrefChange.push(function(pref) {
-            if (player && pref === "volume") {
-                player.volume = OPTIONS[pref] / 100;
-            }
-        });
+        handleVolChange(player);
     }
 
     function fallback() {

diff --git a/data/common.js b/data/common.js
@@ -91,6 +91,14 @@ function logify(...args) {
     console.log.apply(console, args.map(s => JSON.stringify(s, null, 2)));
 }
 
+function handleVolChange(player) {
+    onPrefChange.push(function(pref) {
+        if (player && pref === "volume") {
+            player.volume = OPTIONS[pref] / 100;
+        }
+    });
+}
+
 function onReady(f) {
     //TODO: document readyState is "loading" (and DOMECotentLoaded) even DOM elements are
     //accessible

diff --git a/data/dailymotion.js b/data/dailymotion.js
@@ -36,10 +36,6 @@
 
         document.body.innerHTML = "";
         document.body.appendChild(player);
-        onPrefChange.push(function(pref) {
-            if (player && pref === "volume") {
-                player.volume = OPTIONS[pref] / 100;
-            }
-        });
+        handleVolChange(player);
     }
 }());
diff --git a/data/facebook.js b/data/facebook.js
@@ -23,10 +23,6 @@
 
         document.getElementsByClassName("_53j5")[0].innerHTML = "";
         document.getElementsByClassName("_53j5")[0].appendChild(player);
-        onPrefChange.push(function(pref) {
-            if (player && pref === "volume") {
-                player.volume = OPTIONS[pref] / 100;
-            }
-        });
+        handleVolChange(player);
     }
 }());
diff --git a/data/metacafe.js b/data/metacafe.js
@@ -26,11 +26,7 @@
             return;
         container.innerHTML = "";
         container.appendChild(player);
-        onPrefChange.push(function(pref) {
-            if (player && pref === "volume") {
-                player.volume = OPTIONS[pref] / 100;
-            }
-        });
+        handleVolChange(player);
     }
 
     function channelPage() {

diff --git a/data/vimeo.js b/data/vimeo.js
@@ -34,11 +34,7 @@
                     //                        type: conf.type
             }));
             player_container.appendChild(player);
-            onPrefChange.push(function(pref) {
-                if (player && pref === "volume") {
-                    player.volume = OPTIONS[pref] / 100;
-                }
-            });
+            handleVolChange(player);
         } catch (e) {
             console.error("Exception on changePlayer()", e.lineNumber, e.columnNumber, e.message, e.stack);
         }

diff --git a/data/youtube.js b/data/youtube.js
@@ -13,11 +13,7 @@
         window.addEventListener("spfdone", function() {
             changePlayer();
         });
-        onPrefChange.push(function(pref) {
-            if (player && pref === "volume") {
-                player.volume = OPTIONS[pref] / 100;
-            }
-        });
+        handleVolChange(player);
     }
     onReady(main);