Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added to filter func for links with spaces #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bradchesney79
Copy link

Heyo, ran into a crash when the tool finds a link like this:

https://dumbguy.com/i suck at making links.html

For whatever reason adding ' ' and \s to the ignore list didn't work for me, which is what I tried first.

@tinyjin
Copy link
Owner

tinyjin commented Aug 9, 2019

Hi~ bradchesney79!

Thank you for your interest in my library.
I crawled https://dumbguy.com. but I can't faced crash error like story you told me.

That crawled result is

error: null
siteMap: undefined

If really has crash error, I want to accept your P/R.
Could you tell me a other link that can cause same errors.

@bradchesney79
Copy link
Author

One last idea-- I suppose we could swap out URL path spaces with a URL encoded space, i.e. %20... For now I am satisfied with marking it as a bad URL...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants